[Marble-devel] Review Request 124519: Jump to current location button for Marble Maps

[Dennis Nienhüser]

> On July 28, 2015, 11:16 p.m., Torsten Rahn wrote:
> > We still need better icons than this. The icon for "Jump to current location" needs to go well with our actual indicator for the current position (which needs to be bigger and more prominent).
> 
> Torsten Rahn wrote:
>     I can draw those icons but we should discuss tomorrow how things should look like.

Let's just use plain (unaltered) Material icons. They look wonderful, people are used to them and they have a CC-BY license. Download at https://www.google.com/design/icons/, we can ship whatever we need with Marble. We'll find a solution for theming problems if they arise, but it's not an important topic right now.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519/#review83119
-----------------------------------------------------------


On July 28, 2015, 11:04 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124519/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 11:04 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position. The button should be visible if the position is known.
> 
> I have also updated the icons. I think with using black borders for white icons we can handle both the dark and the light themes.
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/locate.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/search.png 599a3c7ccdcedb11835378562f7f34c2a4c39669 
>   src/apps/marble-maps/CircleButton.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml 5552a54eca8b37fa17588a14a035927418b23fbe 
>   src/apps/marble-maps/MarbleMaps.qrc c24c38a507da4a8d41729d61fc23035d6f75a446 
>   src/lib/marble/MarbleQuickItem.h 21b8fe5c4570ac894f668603a660da81f1d8a8e4 
>   src/lib/marble/MarbleQuickItem.cpp ee8bae8ea379cae3a0e6378259622a1ad88f8a2b 
> 
> Diff: https://git.reviewboard.kde.org/r/124519/diff/
> 
> 
> Testing
> -------
> 
> It seems calling update() stops for the position providing plugin when I turn off the locationing -> It can not hide the button, because no signal has been emitted about status change. Any ideas?
> 
> 
> File Attachments
> ----------------
> 
> search.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/d1e80eda-39e0-4c53-b09a-59b115d95785__search.png
> locate.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/8461a526-bfbf-4298-af71-e99616964e62__locate.png
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/5b1f5fe0-d02d-415e-aa49-3cf20dedab0b__Screenshot_2015-07-29-00-49-51.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150729/55430618/attachment-0001.html>