[Marble-devel] Review Request 124498: Properly placed street labels with font style and color settings.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124498/#review83105
-----------------------------------------------------------



src/lib/marble/GeoPainter.cpp (line 539)
<https://git.reviewboard.kde.org/r/124498/#comment57382>

    This is not going to fly! :-)
    
    Here we have TWO drawPolyline methods with 
    - a very different labeling implementation each
    - one of them being significantly slower
    - one which ignores the labelPositionFlag and inherently comes up with a new means to position the label.
    
    Either we add a new labelPositioning Flag value to both methods and have the same new "Label Follows Line" value implemented in both drawPolyline methods.
    
    OR we rename this method to something different like "drawPath()". 
    
    Personally I'd prefer the first approach - but this would require a bit of refactoring.


- Torsten Rahn


On Juli 28, 2015, 1:54 nachm., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124498/
> -----------------------------------------------------------
> 
> (Updated Juli 28, 2015, 1:54 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> With this patch, the street labels are renedered properly in OSM Vector Tiles. For each type of OSM way, a custom font style and color can be defined. They even follow the curvatures of the streets without any major performance impact.
> As for the font styles, I welcome any suggestions in the commemnts.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/ClipPainter.h 42b73c0 
>   src/lib/marble/ClipPainter.cpp 473436e 
>   src/lib/marble/GeoPainter.h 7a757b9 
>   src/lib/marble/GeoPainter.cpp d04138c 
>   src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 
>   src/lib/marble/geodata/data/GeoDataFeature.cpp 6f330fb 
>   src/lib/marble/geodata/data/GeoDataFeature_p.h 496c356 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 
>   src/lib/marble/layers/GeometryLayer.cpp 9eb3f50 
> 
> Diff: https://git.reviewboard.kde.org/r/124498/diff/
> 
> 
> Testing
> -------
> 
> I was worried about the performance impact, because my initial idea was too slow, but after several changes, this version works pretty good.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150728/daaed572/attachment-0001.html>