[Marble-devel] Review Request 124498: Properly placed street labels with font style and color settings.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124498/#review83071
-----------------------------------------------------------



src/lib/marble/GeoPainter.cpp (line 565)
<https://git.reviewboard.kde.org/r/124498/#comment57354>

    Curly brackets and newline missing. Alternatively, if you prefer a one-liner, use `fontSize = qMin( fontSize, maximumLabelFontSize );`



src/lib/marble/GeoPainter.cpp (line 598)
<https://git.reviewboard.kde.org/r/124498/#comment57355>

    Curly brackets and newline, or sth like `angle = angle < 0 ? angle + 360 : angle;`



src/lib/marble/GeoPainter.cpp (line 609)
<https://git.reviewboard.kde.org/r/124498/#comment57356>

    what about introducing a private method like `drawTextRotated( const QPointF &center, qreal angle, const QString &text )` that does these steps? The same is done below, would shorten the method and avoid code duplication.



src/lib/marble/GeoPainter.cpp (line 623)
<https://git.reviewboard.kde.org/r/124498/#comment57357>

    brackets, newline. or have a private normalizeAngle method?


- Dennis Nienhüser


On July 27, 2015, 9:40 p.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124498/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:40 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> With this patch, the street labels are renedered properly in OSM Vector Tiles. For each type of OSM way, a custom font style and color can be defined. They even follow the curvatures of the streets without any major performance impact.
> As for the font styles, I welcome any suggestions in the commemnts.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/ClipPainter.h 42b73c0 
>   src/lib/marble/ClipPainter.cpp 473436e 
>   src/lib/marble/GeoPainter.h 7a757b9 
>   src/lib/marble/GeoPainter.cpp d04138c 
>   src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 
>   src/lib/marble/geodata/data/GeoDataFeature.cpp 6f330fb 
>   src/lib/marble/geodata/data/GeoDataFeature_p.h 496c356 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 
>   src/lib/marble/layers/GeometryLayer.cpp 9eb3f50 
> 
> Diff: https://git.reviewboard.kde.org/r/124498/diff/
> 
> 
> Testing
> -------
> 
> I was worried about the performance impact, because my initial idea was too slow, but after several changes, this version works pretty good.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150728/8ddc7306/attachment.html>