[Marble-devel] Review Request 124492: Normalized SIGNAL and SLOT signatures

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124492/#review83060
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On July 27, 2015, 4:20 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124492/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 4:20 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Krazy2 findings "Check for normalized SIGNAL and SLOT signatures" fixed, using the normalize tool from qtrepotools.
> 
> 
> Diffs
> -----
> 
>   examples/cpp/squad-interpolation/squad-interpolation.cpp 7c4f5bd51e5d9bc00683ca65e20c2a189ace2e52 
>   examples/cpp/tour-preview/tour-preview.cpp 52e4194ab5fe13eff29c36b3759bf5cc5868b92b 
>   src/apps/marble-kde/marble_part.cpp b6e9829540e6c17b96361c8619e532b00a29e3d3 
>   src/apps/marble-qt/QtMainWindow.cpp 3ae8471c8b8c8f65a2701a0f8c7fd62b3fa3322f 
>   src/lib/marble/AnimatedUpdateTrack.cpp 382f7c3d3b946dcce49724b655a66ed5ba10adcc 
>   src/lib/marble/EditPlacemarkDialog.cpp 8b19f148e8c10c51657c14f41160f897922e2dfb 
>   src/lib/marble/FormattedTextWidget.cpp 76a6a4c9a812e5b4bcb5bf89cead3b977c50ff5d 
>   src/lib/marble/LegendWidget.cpp 7399e57c8ea618c34abdb951ffa2831aadccdf1d 
>   src/lib/marble/MarbleModel.cpp 81d48b4561f080c4f0e4ffaad544e85544c5849c 
>   src/lib/marble/MarbleWidget.cpp d97ac68e6637a7af671f8c94b30df8782e389423 
>   src/lib/marble/PlaybackFlyToItem.cpp 506e3e02cdf154b004d812680974f607b5645c49 
>   src/lib/marble/PlaybackWaitItem.cpp 2d5531ecd584faa7a858c4407730cc38042beb54 
>   src/lib/marble/RemoteIconLoader.cpp eb0fb6cf805462f91f1cecf3fa1750f2d4770f83 
>   src/lib/marble/RenderPlugin.cpp 816a57416f8fbd1d824212428edd3d63604dfdfc 
>   src/lib/marble/SerialTrack.cpp c87f9bd7f55a35857d88d5932109f6b0f0e57f73 
>   src/lib/marble/SoundTrack.cpp cc0e0cb4d64fac6887dd7f7971cb76760f3267fe 
>   src/lib/marble/TourItemDelegate.cpp 2a69da127b3a12d7d41799d90b2e63f0d9ae771e 
>   src/lib/marble/TourPlayback.cpp b77ceaaea35b486ffaaee13ca561466439561bee 
>   src/lib/marble/TourWidget.cpp c38db5b3f61e5a55873906ccf7e92d81165597da 
>   src/lib/marble/cloudsync/RouteSyncManager.cpp 9df5d58e725a6025efabe990239518d09c1f066f 
>   src/lib/marble/routing/RoutingWidget.cpp ea59fac55c2d7aea69d45474f73d42667796f81a 
>   src/plugins/render/annotate/AnnotatePlugin.cpp 100ea4faa3ac9007808663a2da1522d93ea8ffd9 
>   src/plugins/render/annotate/EditPolygonDialog.cpp abec4a4a3eea8096289ee19b267ffd89cc8908c8 
>   src/plugins/render/annotate/EditPolylineDialog.cpp 36246e2d6402a472859fabaf75b32e09db40b12f 
>   src/plugins/render/annotate/NodeItemDelegate.cpp 250a27e1dc3fcc58023a91c8898667e7dcb387dc 
>   src/plugins/render/eclipses/EclipsesPlugin.cpp 45a81f3340140f3bd9afeca257db839af1d54ea2 
> 
> Diff: https://git.reviewboard.kde.org/r/124492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150727/a8f10483/attachment.html>