[Marble-devel] Review Request 124466: [MarbleMaps] Add search bar and "Theme item" for Marble Maps.

[Mihail Ivchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124466/
-----------------------------------------------------------

(Updated July 26, 2015, 11:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for Marble and Gábor Péterffy.


Changes
-------

Submitted with commit a19e608a2b3ad87ce5fe6c51b548459daf3ad7a1 by Mikhail Ivchenko on behalf of Gábor Péterffy to branch master.


Repository: marble


Description
-------

Based on [work of Gábor Péterffy](https://git.reviewboard.kde.org/r/124327/)


Diffs
-----

  data/android/drawable-xxxhdpi/search.png PRE-CREATION 
  src/apps/marble-maps/CMakeLists.txt ea6ca1e 
  src/apps/marble-maps/MainScreen.qml 8f50962 
  src/apps/marble-maps/MarbleMaps.qrc 6bb2336 
  src/apps/marble-maps/Search.qml PRE-CREATION 
  src/apps/marble-maps/SearchBackend.h PRE-CREATION 
  src/apps/marble-maps/SearchBackend.cpp PRE-CREATION 
  src/apps/marble-maps/SearchField.qml PRE-CREATION 
  src/apps/marble-maps/SearchResults.qml PRE-CREATION 
  src/apps/marble-maps/Theme.qml PRE-CREATION 
  src/apps/marble-maps/main.cpp 08f4be5 
  src/lib/marble/MarblePlacemarkModel.cpp b814fdb 
  src/lib/marble/MarbleQuickItem.h fa61707 

Diff: https://git.reviewboard.kde.org/r/124466/diff/


Testing
-------

Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1).
Only issue I noticed:
After starting UI doesn't for few sec (looks like because of plugins loading). But that issue wasn't caused by this patch but previous one.


File Attachments
----------------

search.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/e875539c-62ec-4b71-a49c-20f477187eed__search.png
Screenshot_2015-07-26-00-42-05.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/835ab63a-aca5-4efa-a868-601b8b15f70e__Screenshot_2015-07-26-00-42-05.png
Screenshot_2015-07-26-00-42-15.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/977187a9-0fc3-43bf-b050-d819476c2afb__Screenshot_2015-07-26-00-42-15.png
Screenshot_2015-07-26-00-42-28.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/357df10d-5170-4e58-808f-6fece05327f6__Screenshot_2015-07-26-00-42-28.png
Screenshot_2015-07-26-00-42-50.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/ce250cea-47e9-4829-b705-370daf431742__Screenshot_2015-07-26-00-42-50.png
Screenshot_2015-07-26-00-43-05.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/e5ebe15e-b394-42ce-a2d1-ba729cf00780__Screenshot_2015-07-26-00-43-05.png


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150726/69ee0ad1/attachment.html>