[Marble-devel] Review Request 124461: Fix addSearchResult in SearchRunnerManager.
Dennis Nienhüser
dennis at nienhueser.de
Sat Jul 25 13:38:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124461/#review82940
-----------------------------------------------------------
Ship it!
src/lib/marble/SearchRunnerManager.cpp (line 122)
<https://git.reviewboard.kde.org/r/124461/#comment57243>
++count; (prefer prefix increment)
- Dennis Nienhüser
On July 25, 2015, 1:27 p.m., Mihail Ivchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124461/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 1:27 p.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> Before m_model.addPlacemarks was called with count of all placemarks instead of unique one.
> This patch fixes that, so count only of unique placemarks is passed.
>
>
> Diffs
> -----
>
> src/lib/marble/SearchRunnerManager.cpp 2da60ec
>
> Diff: https://git.reviewboard.kde.org/r/124461/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mihail Ivchenko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150725/4a3e8920/attachment.html>
More information about the Marble-devel
mailing list