[Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124440/#review82853
-----------------------------------------------------------



src/apps/marble_maps/MainScreen.qml (line 4)
<https://git.reviewboard.kde.org/r/124440/#comment57150>

    As mentioned in previous review requests I think that 
    - the root element of each custom element should have the id "root" for reasons of consistency and reuse.
    - the background should be added like this:
    
    Item {
        id: root
        
        Rectangle {
            id: background
        }
    }


- Torsten Rahn


On Juli 24, 2015, 7:23 vorm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124440/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2015, 7:23 vorm.)
> 
> 
> Review request for Marble and Gábor Péterffy.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added zooming for Marble Maps.
>     
> This and [that](https://git.reviewboard.kde.org/r/124438/) RRs are based on [work of Gábor Péterffy.](https://git.reviewboard.kde.org/r/124346/) and separated for better commits history and further improvements from my side. GUI for search will be added in next patch.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble_maps/MainScreen.qml 96238c5 
>   src/lib/marble/MarbleQuickItem.h b90e803 
>   src/lib/marble/MarbleQuickItem.cpp e6757fd 
> 
> Diff: https://git.reviewboard.kde.org/r/124440/diff/
> 
> 
> Testing
> -------
> 
> Works on Nexus 5 & Nexus 9 (both Android 5.1.1).
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150724/cc4b21ef/attachment.html>