[Marble-devel] Review Request 124440: [MarbleMaps] Added zooming for Marble Maps.

Mihail Ivchenko ematirov at gmail.com
Fri Jul 24 07:24:00 UTC 2015



> On July 24, 2015, 1:38 a.m., Dennis Nienhüser wrote:
> > Would it be possible to pass the QPointf parameters as const references also?

Yes, fixed.


- Mihail


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124440/#review82846
-----------------------------------------------------------


On July 24, 2015, 11:23 a.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124440/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 11:23 a.m.)
> 
> 
> Review request for Marble and Gábor Péterffy.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added zooming for Marble Maps.
>     
> This and [that](https://git.reviewboard.kde.org/r/124438/) RRs are based on [work of Gábor Péterffy.](https://git.reviewboard.kde.org/r/124346/) and separated for better commits history and further improvements from my side. GUI for search will be added in next patch.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble_maps/MainScreen.qml 96238c5 
>   src/lib/marble/MarbleQuickItem.h b90e803 
>   src/lib/marble/MarbleQuickItem.cpp e6757fd 
> 
> Diff: https://git.reviewboard.kde.org/r/124440/diff/
> 
> 
> Testing
> -------
> 
> Works on Nexus 5 & Nexus 9 (both Android 5.1.1).
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150724/ff921954/attachment-0001.html>


More information about the Marble-devel mailing list