[Marble-devel] Review Request 124421: Route preview was not working. Fixed!

Dennis Nienhüser dennis at nienhueser.de
Thu Jul 23 21:36:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124421/#review82845
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Juli 23, 2015, 7:21 vorm., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124421/
> -----------------------------------------------------------
> 
> (Updated Juli 23, 2015, 7:21 vorm.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> There was an unnecessary check at the beginning of the function because of which the flow was never going down to the point where it should start playing the route as tour. Removed the, and the route preview takes place as required now.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/routing/RoutingWidget.cpp e3e6d9c 
> 
> Diff: https://git.reviewboard.kde.org/r/124421/diff/
> 
> 
> Testing
> -------
> 
> Tested. Works.
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150723/505598f8/attachment-0001.html>


More information about the Marble-devel mailing list