[Marble-devel] Review Request 123594: Refactoring (delegate and view proxy) classes from MapViewWidget

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123594/
-----------------------------------------------------------

(Updated July 19, 2015, 7:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Changes
-------

Submitted with commit a00421b0931dde8867e575a3939de11fb2a6ade3 by Dennis Nienhüser on behalf of Marius Stanciu to branch master.


Repository: marble


Description
-------

Separated the refactoring part of the Map Change patch posted earlier. ( to improve clarity and patch size )

This patch refactors the MapViewItemDelegate and CelestialSortFilterProxy classes from MapViewWidget.cpp to 
extend their use in the MapChangeEditDialog ( https://git.reviewboard.kde.org/r/123406/ )


Diffs
-----

  src/lib/marble/CMakeLists.txt f448f84 
  src/lib/marble/CelestialSortFilterProxyModel.h PRE-CREATION 
  src/lib/marble/CelestialSortFilterProxyModel.cpp PRE-CREATION 
  src/lib/marble/MapViewItemDelegate.h PRE-CREATION 
  src/lib/marble/MapViewItemDelegate.cpp PRE-CREATION 
  src/lib/marble/MapViewWidget.cpp 4d8f9f6 

Diff: https://git.reviewboard.kde.org/r/123594/diff/


Testing
-------

This does no real modification to Marble. Considered compiling it succesfully to be enough of a test.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150719/07d9cda9/attachment.html>