[Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

[Dennis Nienhüser]

> On July 12, 2015, 8:24 p.m., Dennis Nienhüser wrote:
> > src/plugins/render/annotate/AnnotatePlugin.cpp, line 88
> > <https://git.reviewboard.kde.org/r/124099/diff/4/?file=384125#file384125line88>
> >
> >     comment does not match code (and is not needed in my opinion: "don't comment the obvious")
> 
> Marius Stanciu wrote:
>     no idea where that comment came from hehe, I don't remember putting it there.

possibly due to a bad merge. I removed the comments some time ago, see `git show 5e3487e`


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124099/#review82414
-----------------------------------------------------------


On July 15, 2015, 2:43 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124099/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 2:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Choosing .osm file format when saving annotation file now correctly outputs osm files.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp c711ccb 
>   src/plugins/runner/osm/CMakeLists.txt 4a341e7 
> 
> Diff: https://git.reviewboard.kde.org/r/124099/diff/
> 
> 
> Testing
> -------
> 
> I have created a bunch of features in the editor ( polygon with hole, polylines, placemarks ), exported them to ".osm" file
> Imported the newly created ".osm" file.
> Exported it to another ".osm" file.
> 
> The initial file and the final one are the same ( except order difference caused by QHash mechanism )
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150716/f5146800/attachment.html>