[Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124095/
-----------------------------------------------------------

(Updated July 15, 2015, 2:17 p.m.)


Review request for Marble.


Changes
-------

mixed up the patch files. fixed issues


Repository: marble


Description
-------

The OsmObjectManager is a temporary solution for managing OSM id ( used to ref osm tags  ). This will be changed as soon as I
find a feasible solution to store osm-specific data in placemarks.

The OsmObjectAttributeWriters is a convenience class used to write typical atributes ( more might be added later )

The OsmTagTagWriter is a tool used to write tags like <tag k="key" v="value">


Diffs (updated)
-----

  src/lib/marble/geodata/writer/GeoWriter.h 1a1a91e 
  src/lib/marble/geodata/writer/GeoWriter.cpp 05762f5 
  src/plugins/runner/osm/CMakeLists.txt 4a341e7 
  src/plugins/runner/osm/OsmObjectManager.h PRE-CREATION 
  src/plugins/runner/osm/OsmObjectManager.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmObjectAttributeWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124095/diff/


Testing
-------

No testing can be done, as these are just helper classes.
Compiles fine


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150715/0a42122f/attachment.html>