[Marble-devel] Review Request 124327: Search Bar has been added for Marble Maps
Torsten Rahn
tackat at kde.org
Wed Jul 15 08:26:23 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124327/#review82506
-----------------------------------------------------------
src/apps/marble_maps/MainScreen.qml (line 29)
<https://git.reviewboard.kde.org/r/124327/#comment56914>
Why should the search bar be a child of the MarbleItem - is there any reason? :)
src/apps/marble_maps/MainScreen.qml (line 12)
<https://git.reviewboard.kde.org/r/124327/#comment56931>
Please always put the id on the top of all other properties and assignments :)
src/apps/marble_maps/SearchBar.qml (line 87)
<https://git.reviewboard.kde.org/r/124327/#comment56932>
I'd rather do:
Item {
Rectangle {
id: background
}
}
src/apps/marble_maps/SearchBar.qml (line 89)
<https://git.reviewboard.kde.org/r/124327/#comment56933>
Why not just refer to "index"? Is there any benefit with this property?
- Torsten Rahn
On Juli 14, 2015, 9:38 nachm., Gábor Péterffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124327/
> -----------------------------------------------------------
>
> (Updated Juli 14, 2015, 9:38 nachm.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.
>
>
> Diffs
> -----
>
> src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION
> src/apps/marble_maps/MainScreen.qml PRE-CREATION
> src/apps/marble_maps/SearchBar.qml PRE-CREATION
> src/apps/marble_maps/SearchBarBackend.h PRE-CREATION
> src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124327/diff/
>
>
> Testing
> -------
>
> On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png
> Screenshot 2
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png
> Screenshot 3
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png
>
>
> Thanks,
>
> Gábor Péterffy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150715/fba6b820/attachment-0001.html>
More information about the Marble-devel
mailing list