[Marble-devel] Review Request 124327: Search Bar has been added for Marble Maps

[Dennis Nienhüser]

> On July 14, 2015, 5:20 p.m., Dennis Nienhüser wrote:
> > Can you give the following layouts a try?
> > 
> > 1) Separating search bar and MarbleItem
> > 
> >     Rectangle {  
> >       SearchBar { 
> >         anchors: top, left and right to parent's respective anchors
> >       }
> >       MarbleItem {
> >         anchors: top to SearchBar, left, right and bottom to parent's respective anchors
> >         PinchArea {anchors.fill: parent}
> >       }
> >     }
> >     
> > 2) SearchBar on top of MarbleItem
> > 
> >     Rectangle {  
> >       MarbleItem {
> >         anchors.fill: parent
> >         PinchArea {anchors.fill: parent}
> >         SearchBar { 
> >           anchors: top, left and right to parent's respective anchors
> >           height: some sane height}
> >       }
> >     }
> > 
> > The second example is pretty similar to what I understand you were trying to achieve. The interesting part is the order of PinchArea and SearchBar, i.e. create PinchArea first. This might fix the problem you describe.

Sorry, meant to post this comment to https://git.reviewboard.kde.org/r/124346 really.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124327/#review82503
-----------------------------------------------------------


On July 14, 2015, 8:08 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124327/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 8:08 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.
> 
> 
> Diffs
> -----
> 
>   data/android/pixmaps/searchFocused.png PRE-CREATION 
>   data/android/pixmaps/searchPressed.png PRE-CREATION 
>   data/android/pixmaps/searchReleased.png PRE-CREATION 
>   src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION 
>   src/apps/marble_maps/QmlView.h PRE-CREATION 
>   src/apps/marble_maps/QmlView.cpp PRE-CREATION 
>   src/apps/marble_maps/SearchBar.qml PRE-CREATION 
>   src/apps/marble_maps/SearchBarBackend.h PRE-CREATION 
>   src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION 
>   src/apps/marble_maps/main.cpp PRE-CREATION 
>   src/lib/marble/MarblePlacemarkModel.cpp a2c78c4f8603752182f64e42e02a585d5ea6b2e3 
>   src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 
>   src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp 7c1803998ce5a01e338f2eb04a2b7f310a926c26 
>   src/plugins/runner/yours/YoursRunner.cpp 4b1c0552718acc4a2f3070e95950975a57d4fdd4 
> 
> Diff: https://git.reviewboard.kde.org/r/124327/diff/
> 
> 
> Testing
> -------
> 
> On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png
> Screenshot 2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png
> Screenshot 3
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150714/254073ac/attachment.html>