[Marble-devel] Review Request 124327: Search Bar has been added for Marble Maps

[Gábor Péterffy]

> On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote:
> > src/apps/marble_maps/SearchBar.qml, line 23
> > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384487#file384487line23>
> >
> >     shouldn't this rather use the height of text?
> 
> Gábor Péterffy wrote:
>     Maybe this is a little bit too small (check the screenshot). Usually the UI's have bigger elements to be more touch "friendly". Which version is better?
> 
> Dennis Nienhüser wrote:
>     Feel free to add some additional space (e.g. a fixed margin, or relative to the size of the text height). My point is mostly that setting its size relative to the screen height introduces a wrong coupling that might work in common situations, but will fail in certain aspect ratios or dpi settings.

On my phone it is okay, maybe some other tester can give feedback for this.


> On júl. 12, 2015, 6:56 du, Dennis Nienhüser wrote:
> > src/apps/marble_maps/SearchBar.qml, line 61
> > <https://git.reviewboard.kde.org/r/124327/diff/2/?file=384487#file384487line61>
> >
> >     i'd rather have the icon (Image) set the size
> 
> Gábor Péterffy wrote:
>     I tried to do that with the width and height properties of the image, but it does nothing. I have to set the button's size or it will be unvisible. Maybe I do something in the wrong way?
> 
> Dennis Nienhüser wrote:
>     Isn't it possible to use the iconSource property directly, see  http://doc.qt.io/qt-5/qml-qtquick-controls-button.html

I had no luck with this option, because it is not resize the image to the buttons size. Any idea?


- Gábor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124327/#review82396
-----------------------------------------------------------


On júl. 13, 2015, 6:09 du, Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124327/
> -----------------------------------------------------------
> 
> (Updated júl. 13, 2015, 6:09 du)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble_maps/QmlView.cpp PRE-CREATION 
>   src/apps/marble_maps/QmlView.h PRE-CREATION 
>   src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
>   data/android/pixmaps/searchUnpressed.png PRE-CREATION 
>   data/android/pixmaps/searchPressed.png PRE-CREATION 
>   data/android/pixmaps/searchFocused.png PRE-CREATION 
>   src/apps/marble_maps/SearchBar.qml PRE-CREATION 
>   src/apps/marble_maps/SearchBarBackend.h PRE-CREATION 
>   src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION 
>   src/apps/marble_maps/main.cpp PRE-CREATION 
>   src/lib/marble/MarblePlacemarkModel.cpp a2c78c4f8603752182f64e42e02a585d5ea6b2e3 
>   src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 
>   src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp 7c1803998ce5a01e338f2eb04a2b7f310a926c26 
>   src/plugins/runner/yours/YoursRunner.cpp 4b1c0552718acc4a2f3070e95950975a57d4fdd4 
> 
> Diff: https://git.reviewboard.kde.org/r/124327/diff/
> 
> 
> Testing
> -------
> 
> On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png
> Screenshot 2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png
> Screenshot 3
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150714/9b19ba80/attachment-0001.html>