[Marble-devel] Review Request 124095: gsoc: Helper classes for OSM writers

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124095/#review82406
-----------------------------------------------------------



src/plugins/runner/osm/OsmObjectManager.h (line 14)
<https://git.reviewboard.kde.org/r/124095/#comment56786>

    not needed here?



src/plugins/runner/osm/OsmObjectManager.h (line 46)
<https://git.reviewboard.kde.org/r/124095/#comment56787>

    should be private and have a m_ prefix



src/plugins/runner/osm/OsmObjectManager.cpp (line 107)
<https://git.reviewboard.kde.org/r/124095/#comment56788>

    qMin is a bit more readable



src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp (line 22)
<https://git.reviewboard.kde.org/r/124095/#comment56789>

    I wonder if we should introduce GeoWriter::writeOptionalAttribute with the same behavior as GeoWriter::writeOptionalElement to spare the if clauses here (just for code readability)


- Dennis Nienhüser


On July 10, 2015, 12:54 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124095/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 12:54 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The OsmObjectManager is a temporary solution for managing OSM id ( used to ref osm tags  ). This will be changed as soon as I
> find a feasible solution to store osm-specific data in placemarks.
> 
> The OsmObjectAttributeWriters is a convenience class used to write typical atributes ( more might be added later )
> 
> The OsmTagTagWriter is a tool used to write tags like <tag k="key" v="value">
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/OsmObjectManager.h PRE-CREATION 
>   src/plugins/runner/osm/OsmObjectManager.cpp PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmObjectAttributeWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmTagTagWriter.h PRE-CREATION 
>   src/plugins/runner/osm/writers/OsmTagTagWriter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124095/diff/
> 
> 
> Testing
> -------
> 
> No testing can be done, as these are just helper classes.
> Compiles fine
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150712/eaa1c2d2/attachment.html>