[Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class
Dennis Nienhüser
dennis at nienhueser.de
Sun Jul 12 17:36:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124231/#review82400
-----------------------------------------------------------
Ship it!
src/lib/marble/osm/OsmPlacemarkData.h (line 127)
<https://git.reviewboard.kde.org/r/124231/#comment56781>
shouldn't be public
- Dennis Nienhüser
On July 10, 2015, 12:48 p.m., Marius Stanciu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124231/
> -----------------------------------------------------------
>
> (Updated July 10, 2015, 12:48 p.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> See comment on the header on what the class is for:
>
> A new folder lib/marble/osm was created because more sources will come in the following patches. Those sources are needed by both the Osm and Annotate plugins, but also the lib itself.
>
> I have tried several approaches for managing osm data, and this seemed the most feasible.
> I have tried making it polymorphic, ( OsmWayData: OsmPlacemarkData and OsmRelationData: OsmPlacemarkData )
> but that approach really made things more complicated and seemed a bit like overdesigning for a simple data container class this is. The empty QHashes barely use any memory, so it should be great.
>
>
> Diffs
> -----
>
> src/lib/marble/CMakeLists.txt 8b36d08
> src/lib/marble/geodata/data/GeoDataCoordinates.h 7b291cc
> src/lib/marble/osm/CMakeLists.txt PRE-CREATION
> src/lib/marble/osm/OsmPlacemarkData.h PRE-CREATION
> src/lib/marble/osm/OsmPlacemarkData.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124231/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marius Stanciu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150712/a34fb936/attachment.html>
More information about the Marble-devel
mailing list