[Marble-devel] Review Request 124327: Search Bar has been added for Marble Maps

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124327/
-----------------------------------------------------------

(Updated júl. 12, 2015, 10:07 de)


Review request for Marble.


Changes
-------

Turned out on Android this is not functional because the lack of a signal (onTextChanged), I have to rethink it...


Repository: marble


Description
-------

This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.


Diffs
-----

  src/plugins/runner/yours/YoursRunner.cpp 4b1c0552718acc4a2f3070e95950975a57d4fdd4 
  src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp 7c1803998ce5a01e338f2eb04a2b7f310a926c26 
  src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 
  src/apps/marble_maps/main.cpp PRE-CREATION 
  src/apps/marble_maps/SearchBarBackend.cpp PRE-CREATION 
  src/apps/marble_maps/SearchBarBackend.h PRE-CREATION 
  src/apps/marble_maps/SearchBar.qml PRE-CREATION 
  src/apps/marble_maps/QmlView.cpp PRE-CREATION 
  src/apps/marble_maps/QmlView.h PRE-CREATION 
  src/apps/marble_maps/MarbleMaps.qrc PRE-CREATION 
  src/apps/marble_maps/MainScreen.qml PRE-CREATION 
  src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
  data/android/pixmaps/searchUnpressed.png PRE-CREATION 
  data/android/pixmaps/searchPressed.png PRE-CREATION 
  data/android/pixmaps/searchFocused.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124327/diff/


Testing (updated)
-------

On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/11/a670df37-4e21-42c0-880a-5e38ba94cc4b__Screenshot_2015-07-11-13-12-22.png


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150712/5093649d/attachment.html>