[Marble-devel] Review Request 124295: QML2 Base for Marble Maps

Dennis Nienhüser dennis at nienhueser.de
Thu Jul 9 17:48:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124295/#review82284
-----------------------------------------------------------



src/apps/marble_maps/CMakeLists.txt (line 2)
<https://git.reviewboard.kde.org/r/124295/#comment56663>

    Not part of the patch?
    Should probably be renamed to e.g. MarbleMaps.qrc also


- Dennis Nienhüser


On July 8, 2015, 1:56 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124295/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 1:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch replaces the QWidget based Marble Maps with a QML2 based one. (It has not had the same functionality yet).
> 
> 
> Diffs
> -----
> 
>   src/apps/CMakeLists.txt 2834e13025bf70a202163992e849a92e2801e1cf 
>   src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
>   src/apps/marble_maps/MainScreen.qml PRE-CREATION 
>   src/apps/marble_maps/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150709/9fb1af06/attachment.html>


More information about the Marble-devel mailing list