[Marble-devel] Review Request 124297: Some qml properties for MarbleQuickItem

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124297/#review82282
-----------------------------------------------------------



src/lib/marble/EnumWrappers.h (line 24)
<https://git.reviewboard.kde.org/r/124297/#comment56660>

    Wouldn't this be better placed inside MarbleQuickItem? It is a QObject already, so just moving the enum (and the Q_ENUMS call) there should suffice



src/lib/marble/MarbleQuickItem.h (line 36)
<https://git.reviewboard.kde.org/r/124297/#comment56661>

    I'd rather get rid of all the showXY properties marble has. Torsten, any opinion?



src/lib/marble/MarbleQuickItem.cpp (line 311)
<https://git.reviewboard.kde.org/r/124297/#comment56662>

    curly brackets are required for one-liners also (kdelibs coding style). Same below.


- Dennis Nienhüser


On July 8, 2015, 4:17 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124297/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 4:17 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> These are added to solve the todo in the example.
> 
>         map()->setShowFrameRate(false);
>         map()->setProjection(Spherical);
>         map()->setMapThemeId("earth/openstreetmap/openstreetmap.dgml");
>         map()->setShowAtmosphere(false);
>         map()->setShowCompass(false);
>         map()->setShowClouds(false);
>         map()->setShowCrosshairs(false);
>         map()->setShowGrid(false);
>         map()->setShowOverviewMap(false);
>         map()->setShowOtherPlaces(false);
>         map()->setShowScaleBar(false);
>         map()->setShowBackground(false);
>         
>   The modification of the example will be in the following patch.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleQuickItem.cpp 94a0a1a498d4be29778f055d6c05bb532f12ee44 
>   src/lib/marble/MarbleQuickItem.h 41e20bb69bbeb9c1d662cd943ecb13674fd04498 
>   src/lib/marble/MarbleGlobal.h cf2768f16c1427ea7f465391827666261b806b80 
>   src/lib/marble/EnumWrappers.cpp PRE-CREATION 
>   src/lib/marble/EnumWrappers.h PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 8b36d0843f585c09c62bf044d0cfb0651a13d4b0 
> 
> Diff: https://git.reviewboard.kde.org/r/124297/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150709/8db4a07b/attachment-0001.html>