[Marble-devel] Review Request 124193: QT_NO_WEBKIT option

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124193/#review82280
-----------------------------------------------------------



CMakeLists.txt (line 69)
<https://git.reviewboard.kde.org/r/124193/#comment56653>

    isn't that check redundant with the one above?



CMakeLists.txt (line 75)
<https://git.reviewboard.kde.org/r/124193/#comment56654>

    seems redundant as well



CMakeLists.txt (line 88)
<https://git.reviewboard.kde.org/r/124193/#comment56655>

    more redundancy. any chance this is the result of a merge gone wrong?



CMakeLists.txt (line 95)
<https://git.reviewboard.kde.org/r/124193/#comment56656>

    can this be done outside the android section? seems the common section does the same?



src/CMakeLists.txt (line 52)
<https://git.reviewboard.kde.org/r/124193/#comment56657>

    Can you add a comment like
    # FIXME Port to Android



src/CMakeLists.txt (line 52)
<https://git.reviewboard.kde.org/r/124193/#comment56658>

    Can you add a comment like
    # FIXME Port to Android


- Dennis Nienhüser


On June 30, 2015, 9:33 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124193/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 9:33 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch includes some little bugfixes and some bulk class to compile without QtWebKit.
> 
> Previous review request:
> https://git.reviewboard.kde.org/r/124064/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt de4a9dc39b948385bdde574dcdb673a9938a186f 
>   src/CMakeLists.txt 78b83a39ac26b17b82b072d6309bb30d88bf6534 
>   src/apps/CMakeLists.txt 2834e13025bf70a202163992e849a92e2801e1cf 
>   src/apps/marble_android/CMakeLists.txt PRE-CREATION 
>   src/apps/marble_android/main.cpp PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 8b36d0843f585c09c62bf044d0cfb0651a13d4b0 
>   src/lib/marble/HttpJob.cpp 249b6800a4c0bfbc944020eb25019400bd4eff34 
>   src/lib/marble/LegendWidget.cpp b74373c92830856f29d3759f682dbf89c3dab6ae 
>   src/lib/marble/MarbleLegendBrowser.h 7e80c389f9e8f0fe3876dc4fe23d917e70a078d9 
>   src/lib/marble/MarbleLegendBrowser.cpp f628b835534063aa459d67ddff10f33466ac59cd 
>   src/lib/marble/NullLegendWidget.ui PRE-CREATION 
>   src/lib/marble/NullMarbleWebView.h PRE-CREATION 
>   src/lib/marble/NullMarbleWebView.cpp PRE-CREATION 
>   src/lib/marble/NullTinyWebBrowser.h PRE-CREATION 
>   src/lib/marble/NullTinyWebBrowser.cpp PRE-CREATION 
>   src/lib/marble/NullWebPopupWidget.ui PRE-CREATION 
>   src/lib/marble/PopupItem.h 4c65004d1386305c3394f5b343bc67cff9127f39 
>   src/lib/marble/PopupItem.cpp 8dd885c6efa4ed1c0981f835339b031720a24d01 
>   src/lib/marble/cloudsync/RouteItemDelegate.cpp 9670f1e3ccb643bab5400e84e01129b9cc6826a4 
>   src/lib/marble/routing/RoutingInputWidget.cpp 40c4aad9a93d3255a66fbfb98487401ee597321e 
>   src/plugins/render/CMakeLists.txt bdfc085f1feca6f94011a3ae32b84a76bbc1602e 
> 
> Diff: https://git.reviewboard.kde.org/r/124193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150709/f6a37d29/attachment.html>