[Marble-devel] Review Request 124231: gsoc: Adds the OsmPlacemarkData class

[Marius Stanciu]

> On July 2, 2015, 7:43 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/osm/OsmPlacemarkData.h, line 131
> > <https://git.reviewboard.kde.org/r/124231/diff/1/?file=382260#file382260line131>
> >
> >     int
> >     
> >     I'd use the same types as https://wiki.openstreetmap.org/wiki/Elements#Common_attributes suggests. Otherwise they'd have to be validated when writing.

thing is, they have to be validated, as they might be missing. Eg. placemarks created within the editor are only given ids ( the other attributes are only generated by the osm server ). I'm also not sure if assigning them a default "not available" value is ok (eg. 0), that's why i've chosen string.


- Marius


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124231/#review82005
-----------------------------------------------------------


On July 2, 2015, 4 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124231/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 4 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> See comment on the header on what the class is for:
> 
> A new folder lib/marble/osm was created because more sources will come in the following patches. Those sources are needed by both the Osm and Annotate plugins, but also the lib itself.
> 
> I have tried several approaches for managing osm data, and this seemed the most feasible.
> I have tried making it polymorphic, ( OsmWayData: OsmPlacemarkData and OsmRelationData: OsmPlacemarkData )
> but that approach really made things more complicated and seemed a bit like overdesigning for a simple data container class this is. The empty QHashes barely use any memory, so it should be great.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 8b36d08 
>   src/lib/marble/geodata/data/GeoDataCoordinates.h 7b291cc 
>   src/lib/marble/osm/CMakeLists.txt PRE-CREATION 
>   src/lib/marble/osm/OsmPlacemarkData.h PRE-CREATION 
>   src/lib/marble/osm/OsmPlacemarkData.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150704/a63a1386/attachment.html>