[Marble-devel] Review Request 124096: gsoc: osm writer classes

Marius Stanciu stanciumarius94 at gmail.com
Thu Jul 2 16:16:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124096/
-----------------------------------------------------------

(Updated July 2, 2015, 4:16 p.m.)


Review request for Marble.


Changes
-------

Modified it to work with the newly introduced OsmPlacemarkData


Repository: marble


Description
-------

Classes with static functions that make writing typical osm tags convenient ( <node>, <way>, <relation>, <osm> )


Diffs (updated)
-----

  src/plugins/runner/osm/writers/OsmNodeTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmRelationTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmTagWriter.cpp PRE-CREATION 
  src/plugins/runner/osm/writers/OsmWayTagWriter.h PRE-CREATION 
  src/plugins/runner/osm/writers/OsmWayTagWriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124096/diff/


Testing
-------

No testing was done yet as these are just static functions, will taste in later patches.
Compiles fine


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150702/efda8a14/attachment-0001.html>


More information about the Marble-devel mailing list