[Marble-devel] Review Request 124217: Changed mable_android to marble_maps

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124217/#review81965
-----------------------------------------------------------



src/apps/marble_maps/CMakeLists.txt (line 28)
<https://git.reviewboard.kde.org/r/124217/#comment56291>

    Does adding
    NAME "Marble Maps"
    have a positive effect?
    
    What effect would have adding
    PACKAGE_NAME "org.kde.marble.maps"
    have?


- Dennis Nienhüser


On June 30, 2015, 10:37 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124217/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 10:37 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch changed marble_android to marble_maps and also added some stuff what is needed for an app in Google Play. The package name cannot be changed in the manifest to have a working app, because the generated java code uses this package name.
> 
> 
> Diffs
> -----
> 
>   data/android/AndroidManifest_MarbleMaps.xml.in PRE-CREATION 
>   data/android/drawable-hdpi/marblelogo.png PRE-CREATION 
>   data/android/drawable-ldpi/marblelogo.png PRE-CREATION 
>   data/android/drawable-mdpi/marblelogo.png PRE-CREATION 
>   data/android/drawable-xhdpi/marblelogo.png PRE-CREATION 
>   data/android/drawable-xxhdpi/marblelogo.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/marblelogo.png PRE-CREATION 
>   src/apps/CMakeLists.txt 2834e13025bf70a202163992e849a92e2801e1cf 
>   src/apps/marble_android/CMakeLists.txt PRE-CREATION 
>   src/apps/marble_android/main.cpp PRE-CREATION 
>   src/apps/marble_maps/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124217/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150701/81711565/attachment.html>