[Marble-devel] Review Request 122004: EditPlacemarkDialog & label color fix
Illya Kovalevskyy
illya.kovalevskyy at gmail.com
Sun Jan 11 21:47:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122004/
-----------------------------------------------------------
(Updated Jan. 11, 2015, 9:47 p.m.)
Status
------
This change has been marked as submitted.
Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.
Repository: marble
Description
-------
This patch renames `EditTextAnnotationDialog` to `EditPlacemarkDialog` and introduces a fix to a bug:
- Create a Placemark via "Add Placemark"
- In the `EditTextAnnotationDialog` keep the label color as black.
- Once you closed the dialog the placemark label appears blue. This is correct due to the selected state.
- However once you click the placemark icon with the left mouse button and then invoke the RMB menu via the right mouse button and click "Properties" the text label color incorrectly appears as "blue" in the dialog (while it should be shown as black).
Related GCI-2014 task: https://www.google-melange.com/gci/task/view/google/gci2014/5909169097932800
Diffs
-----
src/lib/marble/EditTextAnnotationDialog.cpp 1472a6f
src/lib/marble/EditTextAnnotationDialog.ui fe64dc2
src/lib/marble/FileViewWidget.cpp f26b21b
src/lib/marble/TourItemDelegate.cpp 326b7ea
src/lib/marble/TourWidget.cpp b0b45da
src/plugins/render/annotate/AnnotatePlugin.cpp 8b2e596
src/lib/marble/CMakeLists.txt bb102df
src/lib/marble/EditPlacemarkDialog.h PRE-CREATION
src/lib/marble/EditPlacemarkDialog.cpp PRE-CREATION
src/lib/marble/EditPlacemarkDialog.ui PRE-CREATION
src/lib/marble/EditTextAnnotationDialog.h db2ad94
src/plugins/render/annotate/PlacemarkTextAnnotation.h 008c666
src/plugins/render/annotate/PlacemarkTextAnnotation.cpp d7f879d
Diff: https://git.reviewboard.kde.org/r/122004/diff/
Testing
-------
Double-testing, everything works as expected, colors get changed normally.
Thanks,
Illya Kovalevskyy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150111/2e53a82d/attachment.html>
More information about the Marble-devel
mailing list