[Marble-devel] Review Request 121940: Viewing properties for placemarks from FileView panel

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121940/
-----------------------------------------------------------

(Updated Jan. 10, 2015, 10:26 p.m.)


Review request for Marble, Bernhard Beschow, Mihail Ivchenko, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

This patch adds "View Properties" feature to newly introduced right mouse click menu on placemarks from `FileView` panel, by reusing `EditTextAnnotationDialog`. This also introduces read-only mode for `EditTextAnnotationDialog`, so placemark data won't get changed anyway.

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5849514216783872


Diffs (updated)
-----

  src/lib/marble/AbstractDataPluginItem.h 83b5e21 
  src/lib/marble/AbstractDataPluginModel.cpp e8c951d 
  src/lib/marble/AnimatedUpdateTrack.cpp ce4d1f1 
  src/lib/marble/CMakeLists.txt bb102df 
  src/lib/marble/EditTextAnnotationDialog.h cafcdac 
  src/lib/marble/EditTextAnnotationDialog.cpp 2f936d0 
  src/lib/marble/ElevationWidget.ui 839a891 
  src/lib/marble/FileViewWidget.h bd44e6d 
  src/lib/marble/FileViewWidget.cpp e0de340 
  src/lib/marble/MarbleAbstractPresenter.cpp 3866354 
  tests/AbstractDataPluginModelTest.cpp ab2d4de 
  tests/CMakeLists.txt 1e775aa 
  tests/LocaleTest.cpp 57baa49 
  src/plugins/render/measure/MeasureToolPlugin.cpp f83b9be 
  src/plugins/render/opencachingcom/OpenCachingComItem.cpp 2acb22f 
  src/lib/marble/projections/AbstractProjection_p.h 98f4264 
  src/lib/marble/projections/SphericalProjection.cpp 910d119 
  src/lib/marble/projections/VerticalPerspectiveProjection.cpp 83a78b0 
  src/plugins/render/annotate/AnnotatePlugin.cpp 8b2e596 
  src/plugins/render/annotate/EditPolygonDialog.cpp ff78331 
  src/plugins/render/measure/MeasureToolPlugin.h e78d381 
  src/lib/marble/MarbleGlobal.h 5027e36 
  src/lib/marble/ViewportParams.h a91cd38 
  src/lib/marble/PlacemarkEditHeader.cpp 9ca61b3 
  src/lib/marble/PlaybackAnimatedUpdateItem.cpp 6e71673 
  src/lib/marble/TourPlayback.cpp 07f4cdb 
  src/lib/marble/ViewportParams.cpp 6a4b468 
  src/lib/marble/geodata/writers/kml/KmlOverlayTagWriter.cpp 06fd2f4 
  src/lib/marble/graphicsview/BillboardGraphicsItem.cpp cae657f 
  src/lib/marble/projections/AbstractProjection.h d760e66 
  src/lib/marble/projections/AbstractProjection.cpp 4806422 
  src/lib/marble/MarbleLocale.h 5244a1e 
  src/lib/marble/MarbleLocale.cpp aa0f72f 
  src/lib/marble/MarbleMap.cpp ac7f8e1 
  src/lib/marble/PlacemarkEditHeader.h 77c8259 

Diff: https://git.reviewboard.kde.org/r/121940/diff/


Testing
-------

Right


File Attachments (updated)
----------------

Context menu
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/99981361-1188-4aa7-a874-47d6c4c72757__Screen_Shot_2015-01-09_at_8.36.13_PM.png
Placemark view
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/10/73a9d9ba-336c-4e40-aaf5-d145e269ecfd__Screen_Shot_2015-01-10_at_10.24.42_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150110/d636c673/attachment-0001.html>