[Marble-devel] Review Request 121888: Unifying handling of different measure systems

Torsten Rahn tackat at kde.org
Sat Jan 10 18:22:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121888/#review73695
-----------------------------------------------------------


Needs adjustments for the pointer-to-reference change in the parameters.

- Torsten Rahn


On Jan. 7, 2015, 8:08 vorm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121888/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 8:08 vorm.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch replaces manual measure sys handling with MarbleLocale::meterToCustomUnit(..) over the codebase, **where it's necessary**.
> 
> Related GCI-2014 task: https://www.google-melange.com/gci/task/view/google/gci2014/5803133938696192
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleAbstractPresenter.cpp 3d47eb5 
>   src/plugins/render/measure/MeasureToolPlugin.h bdcb256 
>   src/plugins/render/measure/MeasureToolPlugin.cpp 2dd4101 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp 12d0101 
> 
> Diff: https://git.reviewboard.kde.org/r/121888/diff/
> 
> 
> Testing
> -------
> 
> Yep
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150110/79df1f75/attachment.html>


More information about the Marble-devel mailing list