[Marble-devel] Review Request 121932: Replacing EARTH_RADIUS in projection classes (approach 1)

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121932/#review73691
-----------------------------------------------------------


Great, but abandoned in favor of approach 2.

- Torsten Rahn


On Jan. 8, 2015, 7:42 nachm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121932/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 7:42 nachm.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch does get rid of EARTH_RADIUS from projection classes, by storing current planet radius in AbstractProjection.
> 
> Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5895892615823360
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleAbstractPresenter.cpp 3d47eb5 
>   src/lib/marble/MarbleMap.cpp 13becfc 
>   src/lib/marble/ViewportParams.h 09aeecb 
>   src/lib/marble/ViewportParams.cpp bca8ea9 
>   src/lib/marble/projections/AbstractProjection.h 719e9f8 
>   src/lib/marble/projections/AbstractProjection.cpp 591adc0 
>   src/lib/marble/projections/AbstractProjection_p.h 7bbfcb5 
>   src/lib/marble/projections/SphericalProjection.cpp c11300b 
>   src/lib/marble/projections/VerticalPerspectiveProjection.cpp 806e028 
> 
> Diff: https://git.reviewboard.kde.org/r/121932/diff/
> 
> 
> Testing
> -------
> 
> Right
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150110/8aaf14ab/attachment-0001.html>