[Marble-devel] Review Request 121939: Do not write name of GeoDataOveray twice.

Torsten Rahn tackat at kde.org
Fri Jan 9 00:16:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121939/#review73539
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Jan. 9, 2015, 12:15 vorm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121939/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 12:15 vorm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It's not necessary to call "writer.writeOptionalElement( kml::kmlTag_name, overlay->name() );" from KmlOverlayTagWriter since "writer.writeOptionalElement( kml::kmlTag_name, feature->name() );" was already called by KmlFeatureTagWriter.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/writers/kml/KmlOverlayTagWriter.cpp fd9490e 
> 
> Diff: https://git.reviewboard.kde.org/r/121939/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150109/2d405fe1/attachment.html>


More information about the Marble-devel mailing list