[Marble-devel] Review Request 121934: Replacing EARTH_RADIUS in projection classes (approach 2)

[Torsten Rahn]

> On Jan. 8, 2015, 7:56 nachm., Bernhard Beschow wrote:
> > I prefer this approach to approach 1 because it lets the projection instances stay `const`.

On the other hand this advantage is traded for planetRadius becoming part of the ViewportParams class (which doesn't really fit much and duplicates its occurance). Any thoughts on that aspect Bernhard? :-)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121934/#review73528
-----------------------------------------------------------


On Jan. 8, 2015, 7:44 nachm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121934/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 7:44 nachm.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch does get rid of EARTH_RADIUS from projection classes, by storing current planet radius in ViewportParams
> 
> Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5895892615823360
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/projections/VerticalPerspectiveProjection.cpp 806e028 
>   src/lib/marble/projections/SphericalProjection.cpp c11300b 
>   src/lib/marble/ViewportParams.cpp bca8ea9 
>   src/lib/marble/ViewportParams.h 09aeecb 
>   src/lib/marble/MarbleModel.cpp 04605c6 
>   src/lib/marble/MarbleModel.h f13491e 
>   src/lib/marble/MarbleMap.h 260d46b 
>   src/lib/marble/MarbleMap.cpp 13becfc 
> 
> Diff: https://git.reviewboard.kde.org/r/121934/diff/
> 
> 
> Testing
> -------
> 
> Right
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150108/8e207e0b/attachment.html>