[Marble-devel] Review Request 121925: [GCI] Fix reading of CDATA status in description.

[Mihail Ivchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121925/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Repository: marble


Description
-------

GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5805500734111744
This patch fixes wrong behavior:

During line 44 QXmlStreamReader::readElementText was called.
It calls readNext while it doesn't read EndElement or error happens.
So, after calling readElementText() usually we'll be at EndElement
And then, we calls "isCDATA()" which makes "return d->type == QXmlStreamReader::Characters && d->isCDATA;",
but current type is not characters but endElement.
So, it always returns false in this case


Diffs
-----

  src/lib/marble/geodata/handlers/kml/KmlDescriptionTagHandler.cpp 56f8918 

Diff: https://git.reviewboard.kde.org/r/121925/diff/


Testing
-------


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150108/13757d86/attachment-0001.html>