[Marble-devel] Review Request 121875: Tweaking MarbleLocale & adding elevation widget to AnnotationPlugin

[Illya Kovalevskyy]

> On Jan. 7, 2015, 1:02 a.m., Bernhard Beschow wrote:
> > src/lib/marble/MarbleLocale.cpp, line 54
> > <https://git.reviewboard.kde.org/r/121875/diff/2/?file=338569#file338569line54>
> >
> >     Please pass those by reference. You seem to depend on the existance of those variables anyway.

(13:33:56) tackat: I don't agree on the reference part
(13:37:30) tackat: it's easier to see in the written code that these parameters are supposed to be modified


> On Jan. 7, 2015, 1:02 a.m., Bernhard Beschow wrote:
> > src/lib/marble/EditTextAnnotationDialog.cpp, line 144
> > <https://git.reviewboard.kde.org/r/121875/diff/2/?file=338564#file338564line144>
> >
> >     the else belongs on the next line, as per coding style

Coding style around the file supposes to leave `else` statement on the same line with closing bracket, doesn't it?


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121875/#review73308
-----------------------------------------------------------


On Jan. 6, 2015, 7:49 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121875/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 7:49 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch expands MarbleLocale API, so it covers measurement units and also does add elevation widget to annotation plugin.
> 
> Related GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5879562479075328
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 807df82 
>   src/lib/marble/EditTextAnnotationDialog.h a842ade 
>   src/lib/marble/EditTextAnnotationDialog.cpp 877f340 
>   src/lib/marble/EditTextAnnotationDialog.ui 67256c6 
>   src/lib/marble/ElevationWidget.ui PRE-CREATION 
>   src/lib/marble/MarbleGlobal.h bd7d63f 
>   src/lib/marble/MarbleLocale.h 0b5414b 
>   src/lib/marble/MarbleLocale.cpp 653f69b 
>   tests/CMakeLists.txt 36ef40b 
>   tests/LocaleTest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121875/diff/
> 
> 
> Testing
> -------
> 
> Positive
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150107/ea610f5c/attachment.html>