[Marble-devel] Review Request 121788: [GCI] Add posibility to add popups\placenames in tours.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121788/#review73005
-----------------------------------------------------------



src/lib/marble/PlacemarkEditHeader.h
<https://git.reviewboard.kde.org/r/121788/#comment50800>

    Please add a const reference :)



src/lib/marble/PlacemarkEditHeader.h
<https://git.reviewboard.kde.org/r/121788/#comment50801>

    please add a const reference :)



src/lib/marble/TourWidget.h
<https://git.reviewboard.kde.org/r/121788/#comment50802>

    It's balloon, not baloon. :)



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/121788/#comment50803>

    Balloon


- Torsten Rahn


On Jan. 2, 2015, 5:52 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121788/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 5:52 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5839784907898880
> and http://www.google-melange.com/gci/task/view/google/gci2014/5789449233367040
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/EditBookmarkDialog.cpp ebc90d2 
>   src/lib/marble/EditTextAnnotationDialog.h 1823a95 
>   src/lib/marble/EditTextAnnotationDialog.cpp 76906fe 
>   src/lib/marble/EditTextAnnotationDialog.ui f968f90 
>   src/lib/marble/PlacemarkEditHeader.h 8bdc24d 
>   src/lib/marble/PlacemarkEditHeader.cpp 305e6c5 
>   src/lib/marble/PlacemarkEditHeader.ui f6e1982 
>   src/lib/marble/TourItemDelegate.h 8354907 
>   src/lib/marble/TourItemDelegate.cpp ed6d836 
>   src/lib/marble/TourPlayback.h d41d3cf 
>   src/lib/marble/TourWidget.h f25cee1 
>   src/lib/marble/TourWidget.cpp 53939ea 
>   src/plugins/render/annotate/AnnotatePlugin.cpp e0828e2 
> 
> Diff: https://git.reviewboard.kde.org/r/121788/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/02/c5984592-37b1-4c3c-b5b9-a81d44321ddd__Add_Balloon.png
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/02/a41b6f60-9708-4bd0-92e7-6929a61532c5__Add_Balloon2.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150103/9659c7d9/attachment.html>