[Marble-devel] Review Request 121776: [GCI] Show file formats that are available for encoding in the Record Movie dialogs

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121776/#review72860
-----------------------------------------------------------



src/lib/marble/MovieCaptureDialog.cpp
<https://git.reviewboard.kde.org/r/121776/#comment50730>

    I guess instead of at(0)  you could use first()



src/lib/marble/TourCaptureDialog.cpp
<https://git.reviewboard.kde.org/r/121776/#comment50731>

    see above



src/lib/marble/TourCaptureDialog.cpp
<https://git.reviewboard.kde.org/r/121776/#comment50732>

    ++i -- let's prefer preincrement.


- Torsten Rahn


On Dez. 31, 2014, 3:55 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121776/
> -----------------------------------------------------------
> 
> (Updated Dez. 31, 2014, 3:55 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5842153850798080
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MovieCapture.h 33a711f 
>   src/lib/marble/MovieCapture.cpp 7b57338 
>   src/lib/marble/MovieCaptureDialog.cpp d259b15 
>   src/lib/marble/TourCaptureDialog.h 4821e09 
>   src/lib/marble/TourCaptureDialog.cpp 66b9e1d 
>   src/lib/marble/TourWidget.cpp e17beac 
> 
> Diff: https://git.reviewboard.kde.org/r/121776/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/31/27185bc7-ecaa-4d10-96cc-baf369a7c387__Available_formats.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150101/83496046/attachment.html>