[Marble-devel] Review Request 122718: Added the possibility to delete graphic items (polygons, lines and placemarks) by pressing the "Delete" key.

[Calin Cruceru]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122718/#review76627
-----------------------------------------------------------


We are getting closer. Respecting the coding style is very important in open source projects as it can be seen by so many people. It is important for you to understand why I am insisting on this.


src/plugins/render/annotate/AnnotatePlugin.cpp
<https://git.reviewboard.kde.org/r/122718/#comment52775>

    Remove trailing whitespace. What editor are you using? Most of them have an option to remove trailing whitespace.
    
    Even if you are using VIM for example, you can easily do:
    
    **:%s/\s+$//g**



src/plugins/render/annotate/AnnotatePlugin.cpp
<https://git.reviewboard.kde.org/r/122718/#comment52776>

    Leave a space before **{**.


- Calin Cruceru


On Feb. 25, 2015, 7:23 p.m., Rares Visalom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122718/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 7:23 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I added the option in the event filter function of the annotate plugin.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp faefeda 
> 
> Diff: https://git.reviewboard.kde.org/r/122718/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rares Visalom
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150225/66b91f2a/attachment.html>