[Marble-devel] Review Request 124989: Edit Maps: Placemark label color highlight on focus (quick fix).

Constantin Mihalache mihalache.c94 at gmail.com
Sun Aug 30 00:02:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124989/
-----------------------------------------------------------

Review request for Marble.


Repository: marble


Description
-------

** bug: **When a placemark is selected (left mouse click) and then deselected, it's label color does not change accordingly (it stays highlighted). When deselecting, the color changes to the original one only if the placemark is dragged out of the screen and then brought back.

* the main issue is that each VisiblePlacemark's labelPixmap should be generated exactly before painting.
* this may not be an elegant fix, but it works


Diffs
-----

  src/lib/marble/VisiblePlacemark.h 805112d 
  src/lib/marble/VisiblePlacemark.cpp 2fdc8ec 

Diff: https://git.reviewboard.kde.org/r/124989/diff/


Testing
-------

Created placemarks -> clicked on the icon of the placemark -> label is highlighted -> clicked on the globe -> label is not highlighted.


Thanks,

Constantin Mihalache

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150830/dcf7c15f/attachment.html>


More information about the Marble-devel mailing list