[Marble-devel] Review Request 124669: [MarbleMaps] Change width of SearchField.

Dennis Nienhüser dennis at nienhueser.de
Sat Aug 29 18:33:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124669/#review84562
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Aug. 9, 2015, 9:18 a.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124669/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 9:18 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Now SearchField fits all width on devices with small width and is situated on top left corner on devices with big width.
> 
> Any suggestions about preferable size limits would be appreciated.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-maps/Search.qml 14088b8df2faec3f045c910189ec7b3032a51805 
> 
> Diff: https://git.reviewboard.kde.org/r/124669/diff/
> 
> 
> Testing
> -------
> 
> Works well on Nexus 5, Nexus 9, Samsung Galaxy Tab Pro 12.2. (Both Nexus are Android 5.1.1, Galaxy Tab is Android 4.4)
> 
> 
> File Attachments
> ----------------
> 
> Nexus 5 (landscape)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/5e518c65-a010-4e9e-a332-b580b5d10f03__Screenshot_2015-08-09-12-45-08.png
> Nexus 5 (portrait)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/9074380d-e335-47de-81e0-e5f0e3ee0381__Screenshot_2015-08-09-12-45-02.png
> Nexus 9 (landscape)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/529d4dab-6188-4f35-9b21-766d61387391__Screenshot_2015-08-09-12-42-40.png
> Nexus 9 (portrait)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/e853d19b-71d3-469e-8647-1d3c104173cb__Screenshot_2015-08-09-12-42-36.png
> Samsung Galaxy Tab Pro 12.2 (landscape)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/08905cb1-1532-4b9e-bbb1-2489db8e73fa__2015-08-09-13-08-41.png
> Samsung Galaxy Tab Pro 12.2 (portrait)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/16100a81-b106-461a-a81d-6a8adca52fae__2015-08-09-13-09-04.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150829/6d074bf1/attachment.html>


More information about the Marble-devel mailing list