[Marble-devel] Review Request 124808: Adding navigation basics to Marble Maps

Gábor Péterffy peterffy95 at gmail.com
Wed Aug 26 17:28:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124808/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 7:28 p.m.)


Review request for Marble.


Changes
-------

It seems the merge is okay now.


Repository: marble


Description
-------

It adds navigation to Marble Maps. I extended the existing Navigation class.


Diffs (updated)
-----

  CMakeLists.txt 5b53ff8 
  data/android/drawable-xxxhdpi/navigation_blue.png PRE-CREATION 
  data/android/drawable-xxxhdpi/place.png bfcc27a 
  data/android/drawable-xxxhdpi/place_green.png 9627dc8 
  data/android/drawable-xxxhdpi/place_orange.png 3bfd4ac 
  data/android/drawable-xxxhdpi/place_red.png 6bca93b 
  data/android/drawable-xxxhdpi/place_white.png 9f55600 
  data/svg/turn-around.svg 11a41e7 
  data/svg/turn-continue.svg 8e865c5 
  data/svg/turn-exit-left.svg 526c750 
  data/svg/turn-exit-right.svg d5c3317 
  data/svg/turn-left.svg 94e6383 
  data/svg/turn-merge.svg 529d050 
  data/svg/turn-right.svg d48a9ef 
  data/svg/turn-roundabout-far.svg a708412 
  data/svg/turn-roundabout-first.svg b1a63b6 
  data/svg/turn-roundabout-second.svg 5b4e222 
  data/svg/turn-roundabout-third.svg 47791ff 
  data/svg/turn-sharp-left.svg 228a1f2 
  data/svg/turn-sharp-right.svg 2c7b6b1 
  data/svg/turn-slight-left.svg befbe52 
  data/svg/turn-slight-right.svg 20bfd63 
  src/apps/marble-maps/CMakeLists.txt 5170175 
  src/apps/marble-maps/MainScreen.qml 23ccf0e 
  src/apps/marble-maps/MarbleMaps.qrc 610e98a 
  src/apps/marble-maps/NavigationInfoBar.qml PRE-CREATION 
  src/apps/marble-maps/NavigationManager.qml PRE-CREATION 
  src/apps/marble-maps/PositionMarker.qml PRE-CREATION 
  src/lib/marble/declarative/MarbleQuickItem.h 1a24034 
  src/lib/marble/declarative/MarbleQuickItem.cpp 05fbc9e 
  src/lib/marble/declarative/Navigation.h 1a2efa7 
  src/lib/marble/declarative/Navigation.cpp 57a5392 
  src/lib/marble/routing/VoiceNavigationModel.cpp 354d278 

Diff: https://git.reviewboard.kde.org/r/124808/diff/


Testing
-------

It works fine ony my device, I have tested it with a little driving around.


File Attachments
----------------

Screenshot_2015-08-18-23-12-11.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/18/f1160c11-8187-4d54-b0f6-d545e4c52e23__Screenshot_2015-08-18-23-12-11.png
navigation_blue.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/5a2d31ab-b85d-4b06-9bda-7e2802d3c8b0__navigation_blue.png


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150826/ef58d65b/attachment.html>


More information about the Marble-devel mailing list