[Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing
Dennis Nienhüser
dennis at nienhueser.de
Sat Aug 22 06:37:27 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124570/#review84172
-----------------------------------------------------------
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 16, 2015, 4:55 p.m., Marius Stanciu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124570/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2015, 4:55 p.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> In order to achieve this, the following has been done:
>
> Wherever geometries are altered within the annotate plugin, I also modified the osmPlacemarkData objects accordingly
> Eg: -a node is deleted =======> a reference within the osmData for that node is removed
> -a node is moved =======> the reference of that node within the osmData is changed to the new coordinates
>
> I also realised there's one extra case at writing time i haven't thought of:
> Placemarks might have semi-initialized osmData.
> Eg. a polygon is loaded from an ".osm" file with complete OsmData. In the editor, a new innerBoundary is added. This new
> boundary does not yet have osmData ).
>
> In order to take this case in consideration, I modified the OsmObjectManager to check for such a case.
>
>
> Diffs
> -----
>
> src/lib/marble/osm/OsmPlacemarkData.h b73a6a0
> src/lib/marble/osm/OsmPlacemarkData.cpp 5665ce5
> src/plugins/render/annotate/AreaAnnotation.cpp fa3bd16
> src/plugins/render/annotate/PolylineAnnotation.cpp 4ae08e8
> src/plugins/runner/osm/OsmObjectManager.cpp 8bebf0c
> src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp 3591b6d
>
> Diff: https://git.reviewboard.kde.org/r/124570/diff/
>
>
> Testing
> -------
>
> Tested every case: loading placemarks from files, creating placemarks, modifying loaded placemarks in every way that i thought of. The results are okay.
> There are a lot of ways to modify placemarks, I might have skipped a few please report any bugs :)
>
>
> Thanks,
>
> Marius Stanciu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150822/7d0ea2bc/attachment-0001.html>
More information about the Marble-devel
mailing list