[Marble-devel] Review Request 124511: Merged the decoration(124154) and the label placement(124498) review requests.

[Dennis Nienhüser]

> On Aug. 21, 2015, 5:22 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/GeoPainter.cpp, line 181
> > <https://git.reviewboard.kde.org/r/124511/diff/6/?file=396498#file396498line181>
> >
> >     this normalization seems a bit overcomplicated, what's the intention?
> 
> Dávid Kolozsvári wrote:
>     This normalizes the angle to the range 0..360 even if it's smaller than -360 or bigger than 720. The calculations are needed.
> 
> Dennis Nienhüser wrote:
>     I'm wondering why you're not using something simpler like the first version in http://stackoverflow.com/a/11498248
> 
> Dávid Kolozsvári wrote:
>     I guess I just didn't do my research. It's even better this way I guess:
>         angle = fmodf(angle, 360);
>         return angle < 0 ? angle + 360 : angle;

Looks good :)


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124511/#review84111
-----------------------------------------------------------


On Aug. 19, 2015, 4:25 p.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124511/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 4:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I changed a little bit the decoration creating method, it now uses a QList to store the decorations, so multiple decorations can be added this way. It was an idea for the street labeling, but it makes sense without that too.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp 81cfe9a 
>   src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.h f469dfb 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.h 4842809 
>   src/lib/marble/geodata/data/GeoDataFeature_p.h 962f0d5 
>   src/lib/marble/geodata/data/GeoDataFeature.cpp 4443162 
>   src/lib/marble/GeoPainter.h 7a757b9 
>   src/lib/marble/GeoPainter.cpp d04138c 
>   src/lib/marble/GeoPainter_p.h f0c4f9b 
>   src/lib/marble/MarbleGlobal.h 8ba5b2d 
>   src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 
>   src/lib/marble/graphicsview/GeoGraphicsItem.h 4ca4727 
>   src/lib/marble/graphicsview/GeoGraphicsItem.cpp b8fa693 
>   src/lib/marble/graphicsview/GeoGraphicsItem_p.h 01becfc 
>   src/lib/marble/layers/GeometryLayer.cpp 11eca7d 
> 
> Diff: https://git.reviewboard.kde.org/r/124511/diff/
> 
> 
> Testing
> -------
> 
> It works on a freshly pulled version of Marble.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150821/2ae7c3d3/attachment.html>