[Marble-devel] Review Request 124858: Adding support for dpi resolution

[Dávid Kolozsvári]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124858/
-----------------------------------------------------------

Review request for Marble.


Repository: marble


Description
-------

I followed the idea behind the mapquality settings, though this wouldn't be changeable directly, but the setDpiResolution() function I think will be needed to set Marble's "internal" dpi resolution to a bigger value when printing.

I added an additional vLowDpi setting for < 60 dpi screens. Is this even needed? We need to test it somehow I guess.


Diffs
-----

  src/apps/marble-qt/QtMainWindow.h ff82641 
  src/apps/marble-qt/QtMainWindow.cpp 4d1b1ea 
  src/lib/marble/MarbleGlobal.h 8ba5b2d 
  src/lib/marble/MarbleMap.h 7b32b7b 
  src/lib/marble/MarbleMap.cpp 2151508 
  src/lib/marble/MarbleWidget.h cd3b9bf 
  src/lib/marble/MarbleWidget.cpp f5d57be 
  src/lib/marble/ViewParams.h 27620bd 
  src/lib/marble/ViewParams.cpp 8eadfa6 

Diff: https://git.reviewboard.kde.org/r/124858/diff/


Testing
-------

The dpi is detected correctly, tried with Kubuntu dpi settings set to 1 and 2 respectively. The "chain" of updateDpiResolution started in QMainWindow reaches ViewwParams, we just need to do something dpi-dependent to be able to test it more thoroughly.


Thanks,

Dávid Kolozsvári

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150821/7007f7ab/attachment.html>