[Marble-devel] Review Request 124808: Adding navigation basics to Marble Maps

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124808/#review84105
-----------------------------------------------------------



src/apps/marble-maps/NavigationManager.qml (line 84)
<https://git.reviewboard.kde.org/r/124808/#comment58244>

    The voice navigation commands are optimized for a limited set of commands recorded from real humans. For text-to-speech we can extend them in the future and provide e.g. distances in the commands as well (ignore in this review request)



src/apps/marble-maps/NavigationManager.qml (line 115)
<https://git.reviewboard.kde.org/r/124808/#comment58243>

    U-turn



src/apps/marble-maps/NavigationManager.qml (line 125)
<https://git.reviewboard.kde.org/r/124808/#comment58241>

    Ahead, exit right!



src/apps/marble-maps/NavigationManager.qml (line 127)
<https://git.reviewboard.kde.org/r/124808/#comment58242>

    Lost GPS connection!



src/lib/marble/declarative/MarbleQuickItem.h (line 192)
<https://git.reviewboard.kde.org/r/124808/#comment58245>

    please move to MarbleQuickItemPrivate



src/lib/marble/declarative/Navigation.h (line 118)
<https://git.reviewboard.kde.org/r/124808/#comment58246>

    doesn't look like a slot and is private. So better remove this method and use d->model() directly.


- Dennis Nienhüser


On Aug. 20, 2015, 11:01 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124808/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 11:01 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It adds navigation to Marble Maps, routing works fine but at the moment the snapping to road and the rerouting not works, I am debugging them now. I used up the existing Navigation class.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5b53ff8 
>   data/svg/turn-around.svg 11a41e7 
>   data/svg/turn-continue.svg 8e865c5 
>   data/svg/turn-exit-left.svg 526c750 
>   data/svg/turn-exit-right.svg d5c3317 
>   data/svg/turn-left.svg 94e6383 
>   data/svg/turn-merge.svg 529d050 
>   data/svg/turn-right.svg d48a9ef 
>   data/svg/turn-roundabout-far.svg a708412 
>   data/svg/turn-roundabout-first.svg b1a63b6 
>   data/svg/turn-roundabout-second.svg 5b4e222 
>   data/svg/turn-roundabout-third.svg 47791ff 
>   data/svg/turn-sharp-left.svg 228a1f2 
>   data/svg/turn-sharp-right.svg 2c7b6b1 
>   data/svg/turn-slight-left.svg befbe52 
>   data/svg/turn-slight-right.svg 20bfd63 
>   src/apps/marble-maps/CMakeLists.txt 33cdaf0 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/NavigationInfoBar.qml PRE-CREATION 
>   src/apps/marble-maps/NavigationManager.qml PRE-CREATION 
>   src/lib/marble/declarative/MarbleQuickItem.h 1a24034 
>   src/lib/marble/declarative/MarbleQuickItem.cpp 05fbc9e 
>   src/lib/marble/declarative/Navigation.h 1a2efa7 
>   src/lib/marble/declarative/Navigation.cpp 57a5392 
>   src/lib/marble/routing/VoiceNavigationModel.cpp 354d278 
> 
> Diff: https://git.reviewboard.kde.org/r/124808/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_2015-08-18-23-12-11.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/18/f1160c11-8187-4d54-b0f6-d545e4c52e23__Screenshot_2015-08-18-23-12-11.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150820/b7842ce5/attachment-0001.html>