[Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

Marius Stanciu stanciumarius94 at gmail.com
Wed Aug 19 15:12:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124672/
-----------------------------------------------------------

(Updated Aug. 19, 2015, 3:12 p.m.)


Review request for Marble.


Changes
-------

Too many patches change the CMakeList file..i will add a separate patch later that manages the CMake file


Repository: marble


Description
-------

Moved the osm presets from the GeoDataFeature to a separate class. This makes accessing the preset styles much easier and clearer.
Added additional tags to the list.


Diffs (updated)
-----

  src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 
  src/lib/marble/geodata/data/GeoDataFeature.cpp 4443162 
  src/lib/marble/geodata/data/GeoDataFeature_p.h 962f0d5 
  src/lib/marble/osm/OsmPresetLibrary.h PRE-CREATION 
  src/lib/marble/osm/OsmPresetLibrary.cpp PRE-CREATION 
  src/plugins/runner/json/JsonParser.cpp 2c1de39 
  src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp f21220d 
  src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 148ea7d 

Diff: https://git.reviewboard.kde.org/r/124672/diff/


Testing
-------


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150819/27e43a93/attachment.html>


More information about the Marble-devel mailing list