[Marble-devel] Review Request 124817: gsoc: Moving the OsmObjectManager from the OsmPlugin

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124817/
-----------------------------------------------------------

(Updated Aug. 19, 2015, 3:10 p.m.)


Review request for Marble.


Changes
-------

Too many patches change the CMakeList file..i will add a separate patch later that manages the CMake file. Manually add the files if you want to test separately


Repository: marble


Description
-------

the osmObjectManager class assigns unique ids to newly created osm placemarks. In the next patches, a relation editor will be added, so this functionality will be needed inside the Annotate Plugin ( not available from the osm plugin )


Diffs (updated)
-----

  src/lib/marble/osm/OsmObjectManager.h PRE-CREATION 
  src/lib/marble/osm/OsmObjectManager.cpp PRE-CREATION 
  src/plugins/runner/osm/CMakeLists.txt b8cef82 
  src/plugins/runner/osm/OsmObjectManager.h a521e07 
  src/plugins/runner/osm/OsmObjectManager.cpp 259826f 
  src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp 24cd423 
  src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp ca91cbc 
  src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp fa74bde 
  src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp 9f56d07 
  src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp 5870ba2 
  src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp bff7a54 
  src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp b0cbd8d 
  src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp 73f115b 
  src/plugins/runner/osm/writers/OsmWayTagWriter.cpp 0b8484c 

Diff: https://git.reviewboard.kde.org/r/124817/diff/


Testing
-------

compiles fine, no other tests needed


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150819/40b96915/attachment-0001.html>