[Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124780/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 8:06 p.m.)


Review request for Marble.


Repository: marble


Description (updated)
-------

!!! depends on the OsmPresetLibrary patch ( 124672 ) 

This widget allows the user to add(remove) tags to placemarks.
The tags can be either selected from a "recommended tags" list, or can be manually introduced via an "Add custom tag..." item.

The recommended tag presets are generated based on the current state of the placemark in the following way:

   - recommendedTags() generates a filter ( using generateTagFilter() ), and then iterates through the osmPresetLibrary, picking all tags that pass the filter.
   - made an easy, standard way to add criteria to the filter( in case there are more feasible ones that i have missed ) as you can see in generateTagFilter();

The widget also has a hint function ( suitableTag() ) that returns the tag that is most fit to represent the visual category of the placemark.
(Currently, the criteria on which that tag is chosen is quite simple ( first tag ), might have to think of a better one )

! known issue (not really related to this patch): not all visual categories have their style mapped right in GeoDataFeature.cpp ( eg. landuse=construction makes the polygon invisible, while landuse=cemetery works perfectly )
might fix the styles in a later patch.


Diffs
-----

  src/lib/marble/CMakeLists.txt 68a4b7f 
  src/lib/marble/osm/CMakeLists.txt 2aa67f7 
  src/lib/marble/osm/OsmTagEditorWidget.h PRE-CREATION 
  src/lib/marble/osm/OsmTagEditorWidget.cpp PRE-CREATION 
  src/lib/marble/osm/OsmTagEditorWidget.ui PRE-CREATION 
  src/lib/marble/osm/OsmTagEditorWidget_p.h PRE-CREATION 
  src/lib/marble/osm/OsmTagEditorWidget_p.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124780/diff/


Testing
-------

testing is done for the next patch ( the ui is not yet integrated in the annotate plugin )


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150816/fd8dd455/attachment.html>