[Marble-devel] Review Request 124666: Added stacking to Marble Maps

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/#review83886
-----------------------------------------------------------


I like the interaction with waypoints directly in the map. We need some bugfixes and tweaks still:
- when the search result is selected and appears on the map, its menu should be opened
- if you change existing waypoints from departure or destination to a via point, they are sometimes excluded from the route
- the waypoint icons in 'Modify Route' are sometimes incorrect
- if you change all waypoints to search results (why is that an option at all?), the app crashes


src/apps/marble-maps/Waypoint.qml (line 52)
<https://git.reviewboard.kde.org/r/124666/#comment58105>

    We already know the geo position. This property recalculates it on every map pan and similar. Let's avoid that.



src/apps/marble-maps/Waypoint.qml (line 65)
<https://git.reviewboard.kde.org/r/124666/#comment58104>

    syntax error, isn't it?



src/lib/marble/declarative/Routing.h (line 105)
<https://git.reviewboard.kde.org/r/124666/#comment58109>

    this one and also updateWaypointItems above and prepareMenu and handleSelectedMenuOption below should be private.



src/lib/marble/declarative/Routing.h (line 107)
<https://git.reviewboard.kde.org/r/124666/#comment58107>

    const QVariant &
    
    In general, method parameters that are not going to be modified by the function are passed
    - by value for simple pod types (bool, int, float, double, enums)
    - by const reference for everything else, including smart pointers and data types with copy-on-write semantics



src/lib/marble/declarative/Routing.h (line 109)
<https://git.reviewboard.kde.org/r/124666/#comment58108>

    const QVariant &



src/lib/marble/declarative/Routing.cpp (line 25)
<https://git.reviewboard.kde.org/r/124666/#comment58110>

    seems unrelated to me?



src/lib/marble/declarative/Routing.cpp (line 157)
<https://git.reviewboard.kde.org/r/124666/#comment58111>

    shouldn't this be `i` instead of `d->m_routeRequestModel->rowCount()-1`?



src/lib/marble/declarative/Routing.cpp (line 222)
<https://git.reviewboard.kde.org/r/124666/#comment58106>

    how is that different from the context property above? And could the context property visible above be set on the item instead to set its visibility?



src/lib/marble/declarative/Routing.cpp (line 260)
<https://git.reviewboard.kde.org/r/124666/#comment58112>

    The tight coupling between QML and C++ in Routing::prepareMenu and Routing::handleSelectedMenuOption is quite awkward. Can't we handle all that directly in QML?


- Dennis Nienhüser


On Aug. 16, 2015, 2:12 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124666/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2015, 2:12 p.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> - Working back button
> - Reworked navigation setup
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/delete_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_arrival.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_departure.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_unknown.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/ic_place_via.png PRE-CREATION 
>   src/apps/marble-maps/CircularMenu.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml cb88a0c 
>   src/apps/marble-maps/MarbleMaps.qrc 1cba58d 
>   src/apps/marble-maps/RoutePlanViewer.qml 4ca794e 
>   src/apps/marble-maps/RoutingManager.qml 6434bff 
>   src/apps/marble-maps/Search.qml 69ecc0a 
>   src/apps/marble-maps/Waypoint.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointImage.qml 9b0aa01 
>   src/apps/marble-maps/WaypointOrderManager.qml c77a460 
>   src/lib/marble/declarative/Routing.h a1e93c5 
>   src/lib/marble/declarative/Routing.cpp 38e0d66 
> 
> Diff: https://git.reviewboard.kde.org/r/124666/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> delete_white.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/10/adb4213f-398d-4c7d-b675-15e3b67ad4a1__delete_white.png
> ic_place_via.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/52e58fcd-8c98-4a20-bc80-42f6e7f2fb20__ic_place_via.png
> ic_place_unknown.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/305b1f56-ccc5-46a7-8c07-883b51f18f64__ic_place_unknown.png
> ic_place_departure.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/9c01956d-6b25-42f8-96fb-e97e9fe15752__ic_place_departure.png
> ic_place_arrival.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/e19d6f8c-0c96-4b76-9b85-610891d3b41b__ic_place_arrival.png
> circular_menu_backdrop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/2a1fd02c-940a-4aee-b8b4-afb66370a70d__circular_menu_backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150816/a51bea1f/attachment-0001.html>