[Marble-devel] Review Request 124511: Merged the decoration(124154) and the label placement(124498) review requests.

[Marius Stanciu]

> On Aug. 10, 2015, 11:25 a.m., Dennis Nienhüser wrote:
> > src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp, line 80
> > <https://git.reviewboard.kde.org/r/124511/diff/2/?file=390457#file390457line80>
> >
> >     Can you check some zoo mappings in OSM to see if this is a building usually?
> 
> Dávid Kolozsvári wrote:
>     Of course it is not, but the problem is something else. I was worried about this, and unfortunately I was right, there is somethin wrong with the parsing:
>     
>     ![parsing problem, "everything" is a building](http://s21.postimg.org/5mw2cwddh/marble_rendering_problem.png)
>     
>     
>     I commented out everything from that switch-case statement, except case `GeoDataFeature::Building:`, and I found that bug shown in the picture above. The area with the blue circle is a zoo(so it should be `GeoDataFeature::TouristZoo`) and the one with red is a castle I guess(it should be `GeoDataFeature::TouristCastle`). But as you can see, each of them is a `GeoDataFeature::Building` and this is a problem. I'm currently trying to firgure out a way to fix this.
> 
> Dennis Nienhüser wrote:
>     The screenshot does not show up here, but the URL http://s21.postimg.org/5mw2cwddh/marble_rendering_problem.png works. Maybe Marius knows what's wrong with parsing directly?

It may be that the zoo placemark has the <tag k="tourism" v="zoo"> and the <tag k="building" v="yes"/> as well, in that order. The tag parsing is quite awkward, choosing a visual category for the placemark based on the last valid tag ( some tags should have priority over others, I think, and it definately shouldn't be order based ). Can you please point me to the location in the image on http://www.openstreetmap.org/ ? So i can check what the osm data looks like :D


- Marius


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124511/#review83652
-----------------------------------------------------------


On Aug. 13, 2015, 12:19 a.m., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124511/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 12:19 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I changed a little bit the decoration creating method, it now uses a QList to store the decorations, so multiple decorations can be added this way. It was an idea for the street labeling, but it makes sense without that too.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/GeoPainter.h 7a757b9 
>   src/lib/marble/GeoPainter.cpp d04138c 
>   src/lib/marble/GeoPainter_p.h f0c4f9b 
>   src/lib/marble/MarbleGlobal.h cf2768f 
>   src/lib/marble/geodata/data/GeoDataFeature.h ea23cd8 
>   src/lib/marble/geodata/data/GeoDataFeature.cpp 6f330fb 
>   src/lib/marble/geodata/data/GeoDataFeature_p.h 496c356 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.h 4842809 
>   src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 4320c07 
>   src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.h f469dfb 
>   src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp 81cfe9a 
>   src/lib/marble/graphicsview/GeoGraphicsItem.h 4ca4727 
>   src/lib/marble/graphicsview/GeoGraphicsItem.cpp b8fa693 
>   src/lib/marble/graphicsview/GeoGraphicsItem_p.h 01becfc 
>   src/lib/marble/layers/GeometryLayer.cpp 9eb3f50 
> 
> Diff: https://git.reviewboard.kde.org/r/124511/diff/
> 
> 
> Testing
> -------
> 
> It works on a freshly pulled version of Marble.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150815/a1ef4d9e/attachment.html>