[Marble-devel] Review Request 124664: [MarbleMaps] Add icons to search results.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124664/#review83585
-----------------------------------------------------------

Ship it!


Looks fine.

I also discussed with Torsten how we can provide different icon sizes easily (larger ones would look better on Android). We don't have a final solution yet, but ideally we arrange icons in a directory structure such that we can load different sizes from a single string. E.g. providing a relative path 'restaurant.png' would lead to an automatic lookup in MarbleDirs for e.g. mapicons/16x16/restaurant.png, mapicons/22x22/restaurant.png and so on. Then we'd need something similar to QIcon that takes a couple of such icon variants and returns the best icon for a queried size (resizing if needed). This would be used internally to implement a new method `QImage GeoDataIconStyle::icon(const QSize &size)`; Probably we cannot use QIcon for that directly because it uses QPixmap internally which does not work with our icon queries coming from non-GUI threads.

- Dennis Nienhüser


On Aug. 8, 2015, 2:30 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124664/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2015, 2:30 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Add icons to search results in Marble Maps.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-maps/SearchResults.qml f6caad10943769f002465ab2618d7900e35817a5 
> 
> Diff: https://git.reviewboard.kde.org/r/124664/diff/
> 
> 
> Testing
> -------
> 
> Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1).
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_2015-08-08-18-12-42.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/08/35dd9737-c1b1-4415-90fd-96392210940f__Screenshot_2015-08-08-18-12-42.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150808/2c7da355/attachment-0001.html>