[Marble-devel] Review Request 124663: gsoc: Fixes style referencing for new polygons and polylines in the annotation plugin

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124663/
-----------------------------------------------------------

(Updated Aug. 8, 2015, 4:16 p.m.)


Review request for Marble.


Repository: marble


Description (updated)
-------

Added more complete default styles for polylines and polygons in the annotationDocuments. These weren't completely set before( only some fields for #polygon, and not at all for #polyline ).
So loading the file in another program( not marble )  might result in different rendering. ( i have searched if the kml standard offers defaults that shouldn't be mentioned; haven't found any ).

In the annotation plugin, when a new polygon(polyline) is added, setStyleUrl( "#polygon" ) is called.
Yet, in the updatePolygon() slot, that style is unnecesarely overwritten on every update( even those not related with style changes ), without changing the styleUrl; 
( when a custom style is set, the #polygon url should not be a valid reference anymore, cause the new style differs from it )


Diffs
-----

  src/lib/marble/geodata/data/GeoDataFeature.cpp a86cb66 
  src/plugins/render/annotate/AnnotatePlugin.cpp b5a816b 
  src/plugins/render/annotate/EditPolygonDialog.h 0dbb089 
  src/plugins/render/annotate/EditPolygonDialog.cpp 6f250b0 
  src/plugins/render/annotate/EditPolylineDialog.h 4d383b8 
  src/plugins/render/annotate/EditPolylineDialog.cpp fe7abc9 

Diff: https://git.reviewboard.kde.org/r/124663/diff/


Testing
-------

creating polyline/polygons---->setting styles--->exporting--->importing: results are as expected


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150808/f502c0d4/attachment.html>