[Marble-devel] Review Request 124627: Markers on map in Marble Maps

Sat Aug 8 10:23:13 UTC 2015

> On Aug. 8, 2015, 5:46 a.m., Dennis Nienhüser wrote:
> > Thanks, the code looks much nicer now.
> > 
> > Some quick usage questions:
> > - How do I hide the "Modify Route" dialog to get back to the map? There is no menu item or button (shown) for it.
> > - What about making the current position the source by default (unless 'As departure' is clicked)? Right now there seems no way to include the current position in the route.
> 
> Gábor Péterffy wrote:
>     I have missed to add this :) Now you cen set your position as departure, and I have updated the menu too. In my opinion too many thing started to be on the screen to handle them with the visible properties, so I would like to introduce a visibility handling class (with this we can also start to use the back button).

Right, visibility handling is starting to become a bit complex/confusing right now. A visibility handler (or state handler?) might help, but I wouldn't want to move everything into it. I wonder if we can reduce things also by merging the route editor and the profile selection buttons into one dialog that is not shown full-screen, but only on the lower ~half of the screen. It could be triggered by a button similar to the current profile selection button. This dialog could also hold the "delete route" button and similar actions.

- Dennis

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124627/#review83540
-----------------------------------------------------------

On Aug. 8, 2015, 9:38 a.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124627/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2015, 9:38 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds the following:
> 
> - Redesigned routing UI
> - Markers on the map
> - Waypoint order editing
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/delete.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/down.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_green.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_orange.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_red.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/place_white.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/up.png PRE-CREATION 
>   src/apps/marble-maps/FloatingMenuButton.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml fafd183 
>   src/apps/marble-maps/MarbleMaps.qrc 713e414 
>   src/apps/marble-maps/NavigationSetup.qml eb7c1dd 
>   src/apps/marble-maps/ProfileSelectorMenu.qml PRE-CREATION 
>   src/apps/marble-maps/RoutingManager.qml PRE-CREATION 
>   src/apps/marble-maps/Search.qml 14088b8 
>   src/apps/marble-maps/WaypointImage.qml PRE-CREATION 
>   src/apps/marble-maps/WaypointOrderManager.qml PRE-CREATION 
>   src/lib/marble/declarative/MarbleQuickItem.h 4b1f729 
>   src/lib/marble/declarative/MarbleQuickItem.cpp feecb00 
>   src/lib/marble/declarative/Placemark.h 8c17b4f 
>   src/lib/marble/declarative/Placemark.cpp 27a9579 
>   src/lib/marble/declarative/RouteRequestModel.cpp c67eb51 
>   src/lib/marble/declarative/Routing.h 51a1be7 
>   src/lib/marble/declarative/Routing.cpp 7a0d8aa 
>   src/lib/marble/declarative/SearchBackend.h 86924f2 
>   src/lib/marble/declarative/SearchBackend.cpp b215d7c 
>   src/lib/marble/routing/RouteRequest.h 60b768b 
>   src/lib/marble/routing/RouteRequest.cpp 441972b 
> 
> Diff: https://git.reviewboard.kde.org/r/124627/diff/
> 
> 
> Testing
> -------
> 
> It works fine except one thing: when you call the redrawRoute() it draws the route until the first placemark, but if you changes the routing profile it draws the full road. Routing instructions are also missing in this case.
> 
> 
> File Attachments
> ----------------
> 
> place_white.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/c34d1f1c-cdb8-4f4b-9c0f-7c9fc479c5a5__place_white.png
> up.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/0dd988f0-189e-4ce6-8dd8-5f4e8f07713a__up.png
> down.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/f0557e37-7c1b-4447-93d2-201c8b05efe4__down.png
> delete.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/fb26b212-cfc0-40d4-90ac-29bbe514dec4__delete.png
> Screenshot I
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/85a13541-3168-499b-9c6a-776f889fe5d7__Screenshot_2015-08-06-01-44-58.png
> Screenshot II
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/2dca53bf-7941-4bd0-8ec2-1e517e915ae8__Screenshot_2015-08-06-01-43-41.png
> Screenshot III
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/7b24796b-a13c-4508-87c7-9861f779a15c__Screenshot_2015-08-06-01-44-51.png
> place_orange.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/323cdff6-7ee6-4d05-a8f1-15e92c6365b6__place_orange.png
> place_green.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/7221416f-7b47-45cf-b5df-ac435b1a3b04__place_green.png
> place_red.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/8decaaeb-8819-400e-8589-e37e9fa7e98d__place_red.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150808/e3112442/attachment.html>